Update to JDK 19 #9421
Merged
Update to JDK 19 #9421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Dec 3, 2022
| @@ -40,8 +40,8 @@ group = "org.jabref" | |||
| version = project.findProperty('projVersion') ?: '100.0.0' | |||
|
|
|||
| java { | |||
| sourceCompatibility = JavaVersion.VERSION_18 | |||
| targetCompatibility = JavaVersion.VERSION_18 | |||
| sourceCompatibility = JavaVersion.VERSION_19 | |||
There was a problem hiding this comment.
I would leave this with 18, so that oeople who stil use 18 can use it as well
There was a problem hiding this comment.
Since we use jlink to compile the jdk with JabRef for distribution it does not matter for the end-user.
For the developer the sourceCompatibility is just a safetynet for not using newer features. The targetCompatibility is the JDK we are using. But we want to be able to use the latest JDK with all the latest security patches. Alternative would be to switch back to 17 LTS, but not to stay stuck on 18.
https://www.baeldung.com/gradle-sourcecompatiblity-vs-targetcompatibility
|
Modernizer plugin fail refs andygoossens/gradle-modernizer-plugin#3 |
ThiloteE
added
the
type: code-quality
* upstream/main: Bump slf4j-api from 2.0.4 to 2.0.5 (#9428) Bump archunit-junit5-api from 1.0.0 to 1.0.1 (#9429) Bump jackson-datatype-jsr310 from 2.14.0 to 2.14.1 (#9430) Bump lucene-highlighter from 9.4.1 to 9.4.2 (#9431) Fix weird checkbox styling (#9425) New translations JabRef_en.properties (Italian) (#9424) New translations JabRef_en.properties (German) (#9418)
This comment was marked as outdated.
This comment was marked as outdated.
Siedlerchr
added
the
status: depends-on-external
* upstream/main: (75 commits) Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493) Enable groups drag'n'drop to new library (#9460) Update MacOS jabrefHost.py to find local installs (#9487) Fix remember last open valid library with empty new one (#9489) Observable Preferences R (CitationKeyPatternPreferences) (#9486) Fixed ZBMathTest and extracted keyWordSeparator (#9485) New Crowdin updates (#9483) Add log for ignored excepton (#9302) Select Library to import into (#9402) Bump org.eclipse.jgit from 6.3.0.202209071007-r to 6.4.0.202211300538-r (#9476) Bump com.github.andygoossens.modernizer from 1.6.2 to 1.7.0 (#9478) Bump mockito-core from 4.9.0 to 4.10.0 (#9479) Bump checkstyle from 10.4 to 10.5.0 (#9477) Bump slf4j-api from 2.0.5 to 2.0.6 in /buildSrc (#9480) Bibtex month not deprecated (#9404) Show development information\n\n+semver: major Release v5.8 Update external libraries add afterburner fx jabref add jakarta inject fix display name for artifact store Prepare CHANGELOG for release ...
Siedlerchr
added
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Dec 27, 2022
* upstream/main: Update to JDK 19 (#9421)
Siedlerchr
added a commit
that referenced
this pull request
Dec 27, 2022
* upstream/main: Update to JDK 19 (#9421)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9417
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)